kangpinghuang commented on a change in pull request #1278: Call delete old
files when all dir convert successfully
URL: https://github.com/apache/incubator-doris/pull/1278#discussion_r292348581
##########
File path: be/src/olap/rowset/segment_group.cpp
##########
@@ -895,4 +928,21 @@ std::string SegmentGroup::_construct_old_file_path(const
std::string& path_prefi
return file_path;
}
+// construct file path for sg_id == -1
+std::string SegmentGroup::_construct_err_sg_file_path(const std::string&
path_prefix, int32_t segment_id, const std::string& suffix) const {
Review comment:
why this function is called err?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
