imay commented on a change in pull request #1280: Support setting 
exec_mem_limit in ExportJob
URL: https://github.com/apache/incubator-doris/pull/1280#discussion_r292388106
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/ExportStmt.java
 ##########
 @@ -221,10 +229,17 @@ private static void checkPath(String path) throws 
AnalysisException {
         throw new AnalysisException("Invalid export path. please use valid 
'HDFS://', 'AFS://' or 'BOS://' path.");
     }
 
-    private void checkProperties(Map<String, String> properties) throws 
AnalysisException {
+    private void checkProperties(Map<String, String> properties) throws 
UserException {
         this.columnSeparator = PropertyAnalyzer.analyzeColumnSeparator(
                 properties, ExportStmt.DEFAULT_COLUMN_SEPARATOR);
         this.lineDelimiter = PropertyAnalyzer.analyzeLineDelimiter(properties, 
ExportStmt.DEFAULT_LINE_DELIMITER);
+        if (properties != null && 
properties.containsKey(LoadStmt.EXEC_MEM_LIMIT)) {
+            try {
+                this.execMemLimit = 
Long.parseLong(properties.get(LoadStmt.EXEC_MEM_LIMIT));
+            } catch (NumberFormatException e) {
+                throw new DdlException("Execute memory limit is not Long", e);
+            }
+        }
 
 Review comment:
   if properties not contain this property, you can get it from SessionVariable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to