imay commented on a change in pull request #1287: Fix creating rollup bug from
multi SegmentGroups generated streaming …
URL: https://github.com/apache/incubator-doris/pull/1287#discussion_r292788549
##########
File path: be/src/olap/olap_table.cpp
##########
@@ -1867,8 +1867,19 @@ void OLAPTable::_list_files_with_suffix(const string&
file_suffix, set<string>*
}
}
-bool OLAPTable::has_version(const Version& version) const {
- return (_data_sources.find(version) != _data_sources.end());
+bool OLAPTable::has_segment_group(const Version& version, const SegmentGroup*
new_segment_group) const {
+ if (_data_sources.find(version) == _data_sources.end()) {
Review comment:
```suggestion
auto it = _data_sources.find(version);
if (it == _data_sources.end()) {
```
and you can avoid seek two times
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
