chenhao7253886 commented on a change in pull request #1292: Support Grouping 
Sets, Rollup and Cube to extend group by statement
URL: https://github.com/apache/incubator-doris/pull/1292#discussion_r292805700
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/Analyzer.java
 ##########
 @@ -584,6 +584,25 @@ public SlotDescriptor registerColumnRef(TableName 
tblName, String colName) throw
         return result;
     }
 
+    public SlotDescriptor registerVirtualColumnRef(String colName, Type type, 
TupleDescriptor tupleDescriptor)
+            throws AnalysisException {
 
 Review comment:
   What is the virtual column ref? add some comments to explain this, 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to