imay commented on a change in pull request #1323: This commit has brought
contribution to streaming mini load
URL: https://github.com/apache/incubator-doris/pull/1323#discussion_r295652567
##########
File path: gensrc/thrift/FrontendService.thrift
##########
@@ -581,9 +608,14 @@ service FrontendService {
MasterService.TMasterResult finishTask(1:MasterService.TFinishTaskRequest
request)
MasterService.TMasterResult report(1:MasterService.TReportRequest request)
MasterService.TFetchResourceResult fetchResource()
+
+ // those three method are used for asynchronous mini load which will be
abandoned
TFeResult miniLoad(1:TMiniLoadRequest request)
TFeResult updateMiniEtlTaskStatus(1:TUpdateMiniEtlTaskStatusRequest
request)
TFeResult loadCheck(1:TLoadCheckRequest request)
+ // this method is used for streaming mini load
+ TMiniLoadBeginResult miniLoadBegin(TMiniLoadBeginRequest request)
+ TFeResult isMiniLoadStreaming()
Review comment:
I think you can make it more common function. like if we add some other
functional, we can reuse this function.
So you can pass function in which is want to be checked
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
