chaoyli commented on a change in pull request #1374: add garbase collect by
rowsetid
URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297024489
##########
File path: be/src/olap/storage_engine.cpp
##########
@@ -944,6 +944,20 @@ OLAPStatus StorageEngine::execute_task(EngineTask* task) {
}
}
+bool StorageEngine::check_path_in_unused_rowsets(const string& path) {
+ _gc_mutex.lock();
+ for (auto& _unused_rowset_pair : _unused_rowsets) {
+ if (_unused_rowset_pair.second->check_path(path)) {
+ LOG(INFO) << "path is found in unused rowsets, path:" << path;
Review comment:
not suggest to print log in lock
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
