yiguolei commented on a change in pull request #1400: Acquire rs readers at the
beginning of the olapscanner
URL: https://github.com/apache/incubator-doris/pull/1400#discussion_r298016738
##########
File path: be/src/exec/olap_scanner.cpp
##########
@@ -474,6 +488,13 @@ Status OlapScanner::close(RuntimeState* state) {
if (_is_closed) {
return Status::OK();
}
+ // olap scan node will call scanner.close() when finished
+ // will release resources here
+ // if not clear rowset readers in read_params here
+ // readers will be release when runtime state deconstructed but
+ // deconstructor in reader references runtime state
+ // so that it will core
Review comment:
It means, we should deconstructor resource in close method. Not in
deconstructor method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
