kangpinghuang commented on a change in pull request #1400: Acquire rs readers
at the beginning of the olapscanner
URL: https://github.com/apache/incubator-doris/pull/1400#discussion_r298018184
##########
File path: be/src/olap/reader.cpp
##########
@@ -452,7 +452,8 @@ OLAPStatus Reader::_capture_rs_readers(const ReaderParams&
read_params) {
const std::vector<RowsetReaderSharedPtr>* rs_readers;
if (read_params.reader_type == READER_ALTER_TABLE
|| read_params.reader_type == READER_BASE_COMPACTION
- || read_params.reader_type == READER_CUMULATIVE_COMPACTION) {
+ || read_params.reader_type == READER_CUMULATIVE_COMPACTION
+ || read_params.reader_type == READER_QUERY) {
rs_readers = &read_params.rs_readers;
} else {
_tablet->obtain_header_rdlock();
Review comment:
Can rowsets be aquired in the same method as other types for CHECK_SUM?
Or it looks odd.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
