morningman commented on a change in pull request #1401: Add report version for 
publish task
URL: https://github.com/apache/incubator-doris/pull/1401#discussion_r298566509
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/master/MasterImpl.java
 ##########
 @@ -559,9 +559,17 @@ private void finishPublishVersion(AgentTask task, 
TFinishTaskRequest request) {
         if (request.isSetError_tablet_ids()) {
             errorTabletIds = request.getError_tablet_ids();
         }
+
+        if (request.isSetReport_version()) {
+            // report version is required. here we check if set, for 
compatibility.
+            long reportVersion = request.getReport_version();
+            
Catalog.getCurrentSystemInfo().updateBackendReportVersion(task.getBackendId(), 
reportVersion, task.getDbId());
+        }
 
 Review comment:
   It won’t, updateBackendReportVersion will only increase the version

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to