gaodayue commented on a change in pull request #1413: Add short key index
builder, decoder, iterator
URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r298908687
##########
File path: be/src/olap/olap_index.h
##########
@@ -133,37 +127,35 @@ struct RowBlockPosition {
char message[1024] = {'\0'};
snprintf(message,
sizeof(message),
- "{segment=%u block_size=%u data_offset=%u index_offset=%u}",
+ "{segment=%u data_offset=%u}",
segment,
- block_size,
- data_offset,
- index_offset);
+ data_offset);
return std::string(message);
}
uint32_t segment;
- uint32_t block_size;
uint32_t data_offset; // offset in data file
- uint32_t index_offset; // offset in index file
};
// In memory presentation of index meta information
struct SegmentMetaInfo {
SegmentMetaInfo() {
range.first = range.last = 0;
- buffer.length = 0;
- buffer.data = NULL;
+ buffer.size = 0;
+ buffer.data = nullptr;
}
const size_t count() const {
return range.last - range.first;
}
IDRange range;
- EntrySlice buffer;
+ Slice buffer;
FileHeader<OLAPIndexHeaderMessage, OLAPIndexFixedHeader> file_header;
};
+class MemIndex;
Review comment:
This forward declaration looks redundant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
