kangpinghuang commented on a change in pull request #1413: Add short key index 
builder, decoder, iterator
URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299431920
 
 

 ##########
 File path: be/src/olap/short_key_index.h
 ##########
 @@ -120,6 +120,11 @@ class ShortKeyIndexIterator {
     inline void seek_to(const RowCursor& key) {
         auto offset = _index->find(key, &_helper, false);
         if (offset.offset > 0) {
+            // The logic of MemIndex sarch is that it will find segment first
 
 Review comment:
   search? seek?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to