imay commented on a change in pull request #1454: Fix parquet load bug
URL: https://github.com/apache/incubator-doris/pull/1454#discussion_r302098511
##########
File path: be/src/exec/parquet_scanner.cpp
##########
@@ -108,22 +98,26 @@ Status ParquetScanner::open_file_reader() {
_cur_file_reader = nullptr;
}
}
- const TBrokerRangeDesc& range = _ranges[_next_range];
- switch (range.file_type) {
- case TFileType::FILE_LOCAL: {
- FileReader *file_reader = new LocalFileReader(range.path,
range.start_offset);
- RETURN_IF_ERROR(file_reader->open());
- _cur_file_reader = new ParquetReaderWrap(file_reader);
- return _cur_file_reader->init_parquet_reader(_src_slot_descs);
- }
- case TFileType::FILE_BROKER: {
- FileReader *file_reader = new BrokerReader(_state->exec_env(),
_broker_addresses, _params.properties, range.path, range.start_offset);
- RETURN_IF_ERROR(file_reader->open());
- _cur_file_reader = new ParquetReaderWrap(file_reader);
- return _cur_file_reader->init_parquet_reader(_src_slot_descs);
+
+ while (true) {
+ if (_next_range >= _ranges.size()) {
+ _scanner_eof = true;
+ return Status::OK();
}
+ const TBrokerRangeDesc &range = _ranges[_next_range++];
+ FileReader *file_reader = nullptr;
Review comment:
```suggestion
FileReader* file_reader = nullptr;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
