morningman commented on a change in pull request #1457: Validate the UTF-8
encode of loading data
URL: https://github.com/apache/incubator-doris/pull/1457#discussion_r302328757
##########
File path: be/src/exec/broker_scanner.cpp
##########
@@ -453,6 +454,16 @@ bool BrokerScanner::convert_one_row(
// Convert one row to this tuple
bool BrokerScanner::line_to_src_tuple(const Slice& line) {
+
+ if (!validate_utf8_fast(line.data, line.size)) {
Review comment:
In case we compile Doris on avx2-support machine and run on avx2-unsupport
machine, the Doris may crash due to Illegal instruction. So I think just using
validate_utf8_fast() is enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
