imay commented on a change in pull request #1475: Fix bug when doing linked
schema change.
URL: https://github.com/apache/incubator-doris/pull/1475#discussion_r303292905
##########
File path: be/src/olap/rowset/segment_group.cpp
##########
@@ -234,27 +235,42 @@ bool SegmentGroup::delete_all_files() {
}
OLAPStatus SegmentGroup::add_zone_maps_for_linked_schema_change(
- const std::vector<std::pair<WrapperField*, WrapperField*>>&
zone_map_fields) {
+ const std::vector<std::pair<WrapperField*, WrapperField*>>&
zone_map_fields,
+ const SchemaMapping& schema_mapping) {
//When add rollup tablet, the base tablet index maybe empty
if (zone_map_fields.size() == 0) {
return OLAP_SUCCESS;
}
- //Should use _num_key_columns, not zone_map_fields.size()
- //as rollup tablet num_key_columns will less than base tablet
zone_map_fields.size().
- //For LinkedSchemaChange, the rollup tablet keys order is the same as base
tablet
+ //1. rollup tablet num_key_columns() will less than base tablet
zone_map_fields.size().
Review comment:
```suggestion
// 1. rollup tablet num_key_columns() will less than base tablet
zone_map_fields.size().
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
