imay commented on a change in pull request #1505: Add timediff function
URL: https://github.com/apache/incubator-doris/pull/1505#discussion_r305707087
##########
File path: fe/src/main/java/org/apache/doris/catalog/PrimitiveType.java
##########
@@ -480,6 +486,7 @@ public static boolean isImplicitCast(PrimitiveType type,
PrimitiveType target) {
compatibilityMatrix[DECIMALV2.ordinal()][DECIMAL.ordinal()] =
DECIMALV2;
compatibilityMatrix[HLL.ordinal()][HLL.ordinal()] = HLL;
+ compatibilityMatrix[TIME.ordinal()][TIME.ordinal()] = TIME;
Review comment:
you should add more relation between time and other types
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]