imay commented on a change in pull request #1409: Add dict page
URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306261145
##########
File path: be/src/olap/rowset/segment_v2/encoding_info.h
##########
@@ -22,18 +22,16 @@
#include "common/status.h"
#include "gen_cpp/segment_v2.pb.h"
#include "olap/types.h"
+#include "olap/rowset/segment_v2/options.h"
+#include "olap/rowset/segment_v2/page_builder.h"
+#include "olap/rowset/segment_v2/page_decoder.h"
namespace doris {
class TypeInfo;
namespace segment_v2 {
-class PageBuilder;
Review comment:
why change forward declaration to include?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
