morningman commented on a change in pull request #1546: Fix bugs of Broker load
URL: https://github.com/apache/incubator-doris/pull/1546#discussion_r307173660
##########
File path:
fe/src/main/java/org/apache/doris/load/loadv2/LoadingTaskPlanner.java
##########
@@ -201,4 +200,17 @@ private String convertBrokerDescPartitionInfo() throws
LoadException, MetaNotFou
}
return result;
}
+
+ // when retry load by reusing this plan in load process, the load_id
should be changed
+ public void updateLoadId(TUniqueId loadId) {
+ for (PlanFragment planFragment : fragments) {
+ if (!(planFragment.getSink() instanceof OlapTableSink)) {
+ continue;
+ }
+ OlapTableSink olapTableSink = (OlapTableSink)
planFragment.getSink();
+ olapTableSink.updateLoadId(loadId);
+ }
+
+ LOG.info("update olap table sink's load id to {}, job: {}",
DebugUtil.printId(loadId), loadJobId);
Review comment:
> Delete this debug log
No, this is not a debug log. We can not find the new load id without this bug
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
