kangpinghuang commented on a change in pull request #1568: initial implementation of BetaRowset URL: https://github.com/apache/incubator-doris/pull/1568#discussion_r310474380
########## File path: be/src/olap/rowset/beta_rowset.h ########## @@ -0,0 +1,69 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#ifndef DORIS_SRC_OLAP_ROWSET_BETA_ROWSET_H_ +#define DORIS_SRC_OLAP_ROWSET_BETA_ROWSET_H_ + +#include "olap/olap_define.h" +#include "olap/rowset/rowset.h" +#include "olap/rowset/rowset_meta.h" +#include "olap/data_dir.h" + +namespace doris { + +class BetaRowset; +using BetaRowsetSharedPtr = std::shared_ptr<BetaRowset>; + +class BetaRowset : public Rowset { +public: + BetaRowset(const TabletSchema* schema, + std::string rowset_path, + DataDir* data_dir, + RowsetMetaSharedPtr rowset_meta); + + virtual ~BetaRowset() {} + + OLAPStatus init() override; + + OLAPStatus load(bool use_cache = true) override; + + std::shared_ptr<RowsetReader> create_reader() override; + + OLAPStatus remove() override; + + OLAPStatus make_snapshot(const std::string& snapshot_path, + std::vector<std::string>* success_links) override; + + OLAPStatus copy_files_to_path(const std::string& dest_path, + std::vector<std::string>* success_files) override; + + // only applicable to alpha rowset, no op here + OLAPStatus remove_old_files(std::vector<std::string>* files_to_remove) override { + return OLAP_SUCCESS; + }; + + bool check_path(const std::string& path) override; + +private: + std::string segment_file_path(const std::string& segment_dir, int segment_id); Review comment: ```suggestion std::string _segment_file_path(const std::string& segment_dir, int segment_id); ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
