imay commented on a change in pull request #1587: Set timezone variable in fe
URL: https://github.com/apache/incubator-doris/pull/1587#discussion_r310588284
##########
File path: fe/src/main/java/org/apache/doris/qe/VariableMgr.java
##########
@@ -203,6 +209,33 @@ private static void checkUpdate(SetVar setVar, int flag)
throws DdlException {
}
}
+ // Check if the time zone_value is valid
+ private static void checkTimeZoneValid(SetVar setVar) throws DdlException {
Review comment:
I think is a common function that can be used by others.
we'd better to put this function another place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
