imay commented on a change in pull request #1590: Implement BetaRowsetWriter
URL: https://github.com/apache/incubator-doris/pull/1590#discussion_r311343477
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -771,6 +779,8 @@ bool SchemaChangeDirectly::process(RowsetReaderSharedPtr
rowset_reader, RowsetWr
<< "block_row_number=" << new_tablet->num_rows_per_row_block();
bool result = true;
RowBlock* new_row_block = nullptr;
+ MemTracker mem_tracker;
+ MemPool mem_pool(&mem_tracker);
Review comment:
You have some problem here. If you put MemPool here, all data allocate from
this MemPool wouldn't be freed until all data has been handled. And when handle
huge rowset, this may result in OOM error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
