imay commented on a change in pull request #1607: Add page cache for column page in BetaRowset URL: https://github.com/apache/incubator-doris/pull/1607#discussion_r311967958
########## File path: be/src/olap/page_cache.cpp ########## @@ -0,0 +1,53 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "olap/page_cache.h" + +namespace doris { + +// This should only be used in unit test. 1GB +static StoragePageCache s_ut_cache(1073741824); Review comment: It make it easy to write unit test for class which depends on this class. Otherwise, developer should call create_global_instance(). And the cost of having an unused object is acceptable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
