kangkaisen commented on a change in pull request #1613: Refactor alter job
process
URL: https://github.com/apache/incubator-doris/pull/1613#discussion_r312018777
##########
File path: fe/src/main/java/org/apache/doris/load/Load.java
##########
@@ -750,24 +741,43 @@ public static void checkAndCreateSource(Database db,
DataDescription dataDescrip
// check negative for sum aggreate type
if (dataDescription.isNegative()) {
- for (Column column : tableSchema) {
+ for (Column column : baseSchema) {
if (!column.isKey() && column.getAggregationType() !=
AggregateType.SUM) {
throw new DdlException("Column is not SUM
AggreateType. column:" + column.getName());
}
}
}
// check hll
- for (Column column : tableSchema) {
+ for (Column column : baseSchema) {
if (column.getDataType() == PrimitiveType.HLL) {
if (assignColumnToFunction != null &&
!assignColumnToFunction.containsKey(column.getName())) {
throw new DdlException("Hll column is not assigned.
column:" + column.getName());
}
}
}
+
// check mapping column exist in table
// check function
// convert mapping column and func arg columns to schema format
+
+ // When doing schema change, there may have some 'shadow' columns,
with prefix '__doris_shadow_' in
+ // their names. These columns are visible to user, but we need to
generate data for these columns.
Review comment:
```suggestion
// their names. These columns are invisible to user, but we need
to generate data for these columns.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
