morningman commented on a change in pull request #1607: Add page cache for
column page in BetaRowset
URL: https://github.com/apache/incubator-doris/pull/1607#discussion_r312303087
##########
File path: be/src/runtime/exec_env_init.cpp
##########
@@ -178,6 +180,18 @@ Status ExecEnv::_init_mem_tracker() {
LOG(INFO) << "Using global memory limit: " <<
PrettyPrinter::print(bytes_limit, TUnit::BYTES);
RETURN_IF_ERROR(_disk_io_mgr->init(_mem_tracker));
RETURN_IF_ERROR(_tmp_file_mgr->init(DorisMetrics::metrics()));
+
+ int64_t storage_cache_limit = ParseUtil::parse_mem_spec(
+ config::storage_page_cache_limit, &is_percent);
+ if (storage_cache_limit > MemInfo::physical_mem()) {
+ LOG(WARNING) << "Config storage_page_cache_limit is greater than
memory size, config="
+ << config::storage_page_cache_limit
+ << ", memory=" << MemInfo::physical_mem();
+ }
+ StoragePageCache::create_global_cache(storage_cache_limit);
Review comment:
Is that OK to set cache size larger than physical memory size?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
