imay commented on a change in pull request #1628: Insert select Stmt keep the
same semantics with mysql (#1626)
URL: https://github.com/apache/incubator-doris/pull/1628#discussion_r312867170
##########
File path: fe/src/main/java/org/apache/doris/qe/StmtExecutor.java
##########
@@ -639,6 +639,11 @@ private void handleInsertStmt() throws Exception {
return;
}
+ if (insertStmt.getQueryStmt() != null && (coord.getCommitInfos()
== null || coord.getCommitInfos().isEmpty())) {
Review comment:
Because we have already begin a transaction for this insert statement, if
you return here now, it will become a pending transaction.
I think that you should abort this transaction before return to user
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
