imay commented on a change in pull request #1627: fix backends disk error
statistics issue
URL: https://github.com/apache/incubator-doris/pull/1627#discussion_r312880575
##########
File path: gensrc/thrift/MasterService.thrift
##########
@@ -64,12 +64,13 @@ struct TTablet {
struct TDisk {
1: required string root_path
- 2: required Types.TSize disk_total_capacity
- 3: required Types.TSize data_used_capacity
- 4: required bool used
- 5: optional Types.TSize disk_available_capacity
- 6: optional i64 path_hash
- 7: optional Types.TStorageMedium storage_medium
+ 2: required Types.TSize data_total_capacity
+ 3: required Types.TSize disk_total_capacity
+ 4: required Types.TSize data_used_capacity
+ 5: required bool used
+ 6: optional Types.TSize disk_available_capacity
+ 7: optional i64 path_hash
+ 8: optional Types.TStorageMedium storage_medium
Review comment:
I think we should change AvailCapacity to the remaining of TotalCapacity,
not the Disk left
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
