gaodayue opened a new issue #1647: V2 segment file should contain no more than INT32_MAX rows URL: https://github.com/apache/incubator-doris/issues/1647 Current V2 segment file allows more than INT32_MAX rows, it uses `uint64_t` to represent row count both in `segment_v2::SegmentWriter` and `SegmentFooterPB`. However bitmap implementations usually only support 32 bits integer, thus in order to support bitmap index later, we should limit row count in each segment to INT32_MAX. Note that I deliberately choose INT32_MAX instead of UINT32_MAX to avoid overflow issue when casting from uint32_t to signed int.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
