morningman commented on a change in pull request #1642: add 
kafka_default_offsets  when no partiotion specify .support read kafka partition 
from start
URL: https://github.com/apache/incubator-doris/pull/1642#discussion_r314215358
 
 

 ##########
 File path: 
fe/src/main/java/org/apache/doris/load/routineload/KafkaRoutineLoadJob.java
 ##########
 @@ -128,6 +132,9 @@ private void convertCustomProperties() throws DdlException 
{
                 convertedCustomProperties.put(entry.getKey(), 
entry.getValue());
             }
         }
+        if (convertedCustomProperties.containsKey(KAFKA_DEFAULT_OFFSETS)) {
+            kafkaDefaultOffSet = 
convertedCustomProperties.get(KAFKA_DEFAULT_OFFSETS);
 
 Review comment:
   ```suggestion
               kafkaDefaultOffSet = 
convertedCustomProperties.remove(KAFKA_DEFAULT_OFFSETS);
   ```
   
   convertedCustomProperties 中只能包含可以被 librdkafka 识别的properties,所以这个default 
offset 需要单独移除

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

Reply via email to