yuanlihan commented on a change in pull request #1635: Enable parsing columns
from file path for Broker Load (#1582)
URL: https://github.com/apache/incubator-doris/pull/1635#discussion_r314612151
##########
File path: be/src/exec/base_scanner.cpp
##########
@@ -179,4 +179,21 @@ bool BaseScanner::fill_dest_tuple(const Slice& line,
Tuple* dest_tuple, MemPool*
}
return true;
}
+
+void BaseScanner::fill_slots_of_columns_from_path(int start, const
std::vector<std::string>& columns_from_path) {
+ if (start <= 0) {
Review comment:
> I think this check is useless
But we should skip the case of StreamLoadTask
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
