imay commented on a change in pull request #1646: Support page compression in
BetaRowset
URL: https://github.com/apache/incubator-doris/pull/1646#discussion_r314950597
##########
File path: be/src/olap/rowset/segment_v2/column_writer.cpp
##########
@@ -222,23 +224,34 @@ Status ColumnWriter::_write_data_page(Page* page) {
return Status::OK();
}
+// compute checksum for page's content
+static uint32_t _compute_checksum(const std::vector<Slice>& slices) {
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
