morningman commented on a change in pull request #1644: Refactor DateLiteral
class in FE
URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r316159393
##########
File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java
##########
@@ -169,36 +238,252 @@ protected void toThrift(TExprNode msg) {
msg.date_literal = new TDateLiteral(getStringValue());
}
- public Date getValue() {
- return date;
- }
-
@Override
protected Expr uncheckedCastTo(Type targetType) throws AnalysisException {
if (targetType.isDateType()) {
return this;
} else if (targetType.isStringType()) {
- return new StringLiteral(getStringValue());
+ return new StringLiteral(getStringValue());
}
Preconditions.checkState(false);
return this;
}
+
+ private long make_packed_datetime () {
Review comment:
```suggestion
private long makePackedDatetime() {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
