imay commented on a change in pull request #1685: Add error msg when memory
limit exceeded
URL: https://github.com/apache/incubator-doris/pull/1685#discussion_r316513179
##########
File path: be/src/exec/exec_node.h
##########
@@ -393,11 +393,15 @@ class ExecNode {
bool _is_closed;
};
-#define RETURN_IF_LIMIT_EXCEEDED(state) \
+#define RETURN_IF_LIMIT_EXCEEDED(state, msg) \
do { \
/* if (UNLIKELY(MemTracker::limit_exceeded(*(state)->mem_trackers())))
{ */ \
- if (UNLIKELY(state->instance_mem_tracker()->any_limit_exceeded())) { \
- return Status::MemoryLimitExceeded("Memory limit exceeded"); \
+ MemTracker* tracker =
state->instance_mem_tracker()->find_limit_exceeded_tracker(); \
+ if (tracker != nullptr) { \
+ stringstream str; \
+ str << "Memory exceed limit. " << msg << " "; \
Review comment:
I think we can add "you can change limit by set exec_mem_limit = "
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
