morningman commented on a change in pull request #1699: Support converting 
RowBatch and RowBlockV2 to/from Arrow
URL: https://github.com/apache/incubator-doris/pull/1699#discussion_r317423529
 
 

 ##########
 File path: be/src/util/arrow/row_block.h
 ##########
 @@ -0,0 +1,65 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include <memory>
+
+#include "common/status.h"
+
+namespace arrow {
+
+class Schema;
+class MemoryPool;
+class RecordBatch;
+
+}
+
+namespace doris {
+
+class Arena;
+class RowBlockV2;
+class Schema;
+
+// Convert Doris Schema to Arrow Schema.
+Status convert_to_arrow_schema(
+    const Schema& row_desc,
+    std::shared_ptr<arrow::Schema>* result);
+
+// Convert Arrow Schema to Doris Schema.
+Status convert_to_doris_schema(
+    const arrow::Schema& schema,
+    std::shared_ptr<Schema>* result);
+
+// Converte a Doris RowBlockV2 to an Arrow RecordBatch. A valid Arrow Schema
 
 Review comment:
   ```suggestion
   // Convert a Doris RowBlockV2 to an Arrow RecordBatch. A valid Arrow Schema
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to