gaodayue commented on issue #1698: refactor RowsetReaderContext
URL: https://github.com/apache/incubator-doris/pull/1698#issuecomment-524696441
 
 
   @imay 
   
   > I think preaggregation and need_ordered_result are different things. When 
preaggregation is true, returning unordered data is OK.
   
   Yes, need_ordered_result is determined by query_type, preaggregation, and 
tablet key type. The logic is 
[here](https://github.com/apache/incubator-doris/pull/1698/files#diff-d356771485a6fb0900e4052964ad9e3fR518).
 Different rowset reader implementations don't have to repeat the logic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to