imay commented on a change in pull request #1694: optimize V2 BinaryPlainPage
format (#1648)
URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317575436
##########
File path: be/src/olap/rowset/segment_v2/binary_plain_page.h
##########
@@ -81,24 +81,21 @@ class BinaryPlainPageBuilder : public PageBuilder {
Slice finish() override {
_finished = true;
- size_t offsets_pos = _buffer.size();
-
- // Set up the header
- encode_fixed32_le(&_buffer[0], _offsets.size());
- encode_fixed32_le(&_buffer[4], offsets_pos);
-
- _buffer.append(&_offsets[0], _offsets.size() * sizeof(uint32_t));
+ // Set up trailer
+ for (int i = 0; i < _offsets.size(); i++) {
+ put_fixed32_le(&_buffer, _offsets[i]);
Review comment:
Why not use variable length encode?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
