yiguolei commented on a change in pull request #1678: Add rowset id generator
to FE and BE
URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318514769
##########
File path: be/src/olap/olap_common.h
##########
@@ -241,7 +246,83 @@ typedef std::set<uint32_t> UniqueIdSet;
// Column unique Id -> column id map
typedef std::map<ColumnId, ColumnId> UniqueIdToColumnIdMap;
-typedef int64_t RowsetId;
+// 8 bit, id version
+// 120 bit, backend random number generated by uuid
+// 64 bit, inc number from 0
+struct RowsetId {
Review comment:
It is useless using ++ , because it will need to get a rowsetidgenerator
object.
Not use pb as a serialize method, we use string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
