yiguolei commented on a change in pull request #1695: Refactor alter job
URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r318950070
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -1332,9 +1332,12 @@ OLAPStatus
SchemaChangeHandler::_do_process_alter_tablet_v2(const TAlterTabletRe
if (res != OLAP_SUCCESS) {
break;
}
- res = _validate_alter_result(new_tablet, request);
} while(0);
+ // _validate_alter_result should be outside the above while loop.
+ // to avoid requiring the header lock twice.
+ res = _validate_alter_result(new_tablet, request);
Review comment:
If the previous step failed, this step will override the result
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
