imay commented on a change in pull request #1705: Limit V2 segment file row
count (#1647)
URL: https://github.com/apache/incubator-doris/pull/1705#discussion_r319457677
##########
File path: be/src/olap/rowset/segment_v2/segment_writer.h
##########
@@ -60,6 +60,8 @@ class SegmentWriter {
uint64_t estimate_segment_size();
+ uint32_t num_rows_written() { return _row_count; }
Review comment:
```suggestion
uint32_t num_rows_written() const { return _row_count; }
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
