morningman commented on a change in pull request #1695: Refactor alter job
URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319787154
##########
File path: fe/src/main/java/org/apache/doris/load/Load.java
##########
@@ -643,16 +634,12 @@ public static void checkAndCreateSource(Database db,
DataDescription dataDescrip
throw new DdlException("Load for AGG_KEYS table should not
specify NEGATIVE");
}
- if (((OlapTable) table).getKeysType() != KeysType.UNIQUE_KEYS &&
deleteFlag) {
- throw new DdlException("Delete flag can only be used for
UNIQUE_KEYS table");
- }
-
// get table schema
- List<Column> tableSchema = table.getBaseSchema();
- Map<String, Column> nameToTableColumn =
Maps.newTreeMap(String.CASE_INSENSITIVE_ORDER);
- for (Column column : tableSchema) {
- nameToTableColumn.put(column.getName(), column);
- }
+ List<Column> baseSchema = table.getBaseSchema();
+ // fill the column info if user does not specify them
+ dataDescription.fillColumnInfoIfNotSpecified(baseSchema);
Review comment:
No, In `fillColumnInfoIfNotSpecified()`, I just want to fill the fields
which user did not fill. After that, these fields should look like user fill
them, not some "after-analyzed" results.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
