gaodayue opened a new pull request #1740: use RowsetFactory to create and init RowsetWriter URL: https://github.com/apache/incubator-doris/pull/1740 The PR contains the following changes - a factory method `create_rowset_writer` is added to `RowsetFactory`. All clients of RowsetWriter have been rewritten to use the factory method to obtain RowsetWriter instance. - a global constant `DEFAULT_ROWSET_TYPE` is added to represent the default rowset type for newly generated rowset. Currently it's set ALPHA_ROWSET, but can be changed to BETA_ROWSET when V2 segment is ready to be released as the default type. - `Merger` is refactored to provides simpler interface to its clients - There is no reason to use shared ownership for RowsetWriter. As a result, `RowsetWriterSharedPtr` is removed and all clients are switched to unique_ptr<RowsetWriter>. - `RowsetIdGenerator.next_id()` is refactored to return RowsetId instead of OLAPStatus since the operation can't fail. It makes the client code much more cleaner. - a new macro `RETURN_NOT_OK_LOG` is added to oneliner the common if-error-then-warn-and-return pattern.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
