morningman commented on a change in pull request #1734: Commit kafka offset in
routine load
URL: https://github.com/apache/incubator-doris/pull/1734#discussion_r320282904
##########
File path: be/src/runtime/routine_load/routine_load_task_executor.cpp
##########
@@ -227,6 +227,28 @@ void RoutineLoadTaskExecutor::exec_task(
// commit txn
HANDLE_ERROR(_exec_env->stream_load_executor()->commit_txn(ctx), "commit
failed");
+ // commit kafka offset
+ switch (ctx->load_src_type) {
+ case TLoadSourceType::KAFKA: {
+ std::shared_ptr<DataConsumer> consumer;
+ HANDLE_ERROR(_data_consumer_pool.get_consumer(ctx, &consumer),
"failed to get consumers");
Review comment:
It's better not return any error if we failed to do something after txn is
committed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
