imay commented on a change in pull request #1745: add delete predicate
filter(#1636)
URL: https://github.com/apache/incubator-doris/pull/1745#discussion_r320726868
##########
File path: be/src/olap/delete_handler.cpp
##########
@@ -343,5 +343,17 @@ void DeleteHandler::finalize() {
_is_inited = false;
}
+void DeleteHandler::get_delete_conditions_after_version(int32_t version,
+ std::vector<const Conditions*>* delete_conditions) const {
+ if (delete_conditions == nullptr) {
Review comment:
can this be nullptr?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
