HangyuanLiu commented on a change in pull request #1734: Commit kafka offset in
routine load
URL: https://github.com/apache/incubator-doris/pull/1734#discussion_r322360317
##########
File path: be/src/runtime/routine_load/data_consumer.h
##########
@@ -133,6 +133,8 @@ class KafkaDataConsumer : public DataConsumer {
// reassign partition topics
virtual Status reset() override;
virtual bool match(StreamLoadContext* ctx) override;
+ // commit kafka offset
+ Status commit(std::vector<RdKafka::TopicPartition*> offset);
Review comment:
librdkafka api is " ErrorCode commitSync (std::vector<TopicPartition*>
&offsets)" , so here can't be const
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
