imay commented on a change in pull request #1778: Fix bug that failed to limit
the mem usage of HLL column when loading
URL: https://github.com/apache/incubator-doris/pull/1778#discussion_r322753911
##########
File path: be/src/olap/aggregate_func.h
##########
@@ -435,7 +436,7 @@ struct
AggregateFuncTraits<OLAP_FIELD_AGGREGATION_HLL_UNION, OLAP_FIELD_TYPE_HLL
slice->data = arena->Allocate(HLL_COLUMN_DEFAULT_LEN);
slice->size = hll->serialize(slice->data);
- delete hll;
+ hll->~HyperLogLog();
Review comment:
should change
[there](https://github.com/apache/incubator-doris/pull/1778/files#diff-6b1f7d667aa162c48abc8d5fd9b4f6b0R428)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
