kangkaisen commented on a change in pull request #1798: Optimize the load
performance for large file
URL: https://github.com/apache/incubator-doris/pull/1798#discussion_r323628862
##########
File path: be/src/olap/delta_writer.h
##########
@@ -75,10 +90,16 @@ class DeltaWriter {
RowsetSharedPtr _new_rowset;
TabletSharedPtr _new_tablet;
std::unique_ptr<RowsetWriter> _rowset_writer;
- MemTable* _mem_table;
+ std::shared_ptr<MemTable> _mem_table;
Schema* _schema;
const TabletSchema* _tablet_schema;
bool _delta_written_success;
+ std::atomic<OLAPStatus> _flush_status;
+ int64_t _flush_cost_ns;
+ int64_t _flush_time;
Review comment:
rename _flush_cost_ns to _flush_time_ns?
rename _flush_time to _flush_count?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
