morningman commented on a change in pull request #1792: Add ChunkAllocator to accelerate chunk allocation URL: https://github.com/apache/incubator-doris/pull/1792#discussion_r323788557
########## File path: be/src/runtime/memory/chunk_allocator.cpp ########## @@ -0,0 +1,187 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "runtime/memory/chunk_allocator.h" + +#include <atomic> +#include <list> +#include <mutex> + +#include "gutil/dynamic_annotations.h" +#include "runtime/memory/chunk.h" +#include "runtime/memory/system_allocator.h" +#include "util/bit_util.h" +#include "util/cpu_info.h" +#include "util/doris_metrics.h" +#include "util/runtime_profile.h" +#include "util/spinlock.h" + +namespace doris { + +ChunkAllocator* ChunkAllocator::_s_instance = nullptr; + +static IntCounter local_core_alloc_count; +static IntCounter other_core_alloc_count; +static IntCounter system_alloc_count; +static IntCounter system_free_count; +static IntCounter system_alloc_cost_ns; +static IntCounter system_free_cost_ns; + +#if BE_TEST +ChunkAllocator* ChunkAllocator::instance() { + if (_s_instance == nullptr) { + DorisMetrics::instance()->initialize("common_ut"); + CpuInfo::init(); + ChunkAllocator::init_instance(4096); + } + return _s_instance; +} +#endif + + +// Keep free chunk's ptr in size separated free list. +// This class is thread-safe. +class ChunkArena { +public: + ChunkArena() : _chunk_lists(64) { } + + ~ChunkArena() { + for (int i = 0; i < 64; ++i) { + if (_chunk_lists[i].empty()) continue; + size_t size = (uint64_t)1 << i; + for (auto ptr : _chunk_lists[i]) { + SystemAllocator::free(ptr, size); + } + } + } + + // Try to pop a free chunk from corresponding free list. + // Return true if success + bool pop_free_chunk(size_t size, uint8_t** ptr) { + int idx = BitUtil::Log2Ceiling64(size); + auto& free_list = _chunk_lists[idx]; + + std::lock_guard<SpinLock> l(_lock); + if (free_list.empty()) { + return false; + } + *ptr = free_list.back(); + free_list.pop_back(); + ASAN_UNPOISON_MEMORY_REGION(*ptr, size); + return true; + } + + void push_free_chunk(uint8_t* ptr, size_t size) { + int idx = BitUtil::Log2Ceiling64(size); + // Poison this chunk to make asan can detect invalid access + ASAN_POISON_MEMORY_REGION(ptr, size); + std::lock_guard<SpinLock> l(_lock); + _chunk_lists[idx].push_back(ptr); + } +private: + SpinLock _lock; + std::vector<std::vector<uint8_t*>> _chunk_lists; +}; + +void ChunkAllocator::init_instance(size_t reserve_limit) { + if (_s_instance != nullptr) return; + _s_instance = new ChunkAllocator(reserve_limit); + +#define REGISTER_METIRC_WITH_NAME(name, metric) \ + DorisMetrics::metrics()->register_metric(#name, &metric) + +#define REGISTER_METIRC_WITH_PREFIX(prefix, name) \ + REGISTER_METIRC_WITH_NAME(prefix##name, name) + +#define REGISTER_METIRC(name) \ + REGISTER_METIRC_WITH_PREFIX(chunk_pool_, name) + + REGISTER_METIRC(local_core_alloc_count); + REGISTER_METIRC(other_core_alloc_count); + REGISTER_METIRC(system_alloc_count); + REGISTER_METIRC(system_free_count); + REGISTER_METIRC(system_alloc_cost_ns); + REGISTER_METIRC(system_free_cost_ns); +} + +ChunkAllocator::ChunkAllocator(size_t reserve_limit) + : _reserve_bytes_limit(reserve_limit), + _reserved_bytes(0), + _arenas(CpuInfo::get_max_num_cores()) { + for (int i = 0; i < _arenas.size(); ++i) { + _arenas[i].reset(new ChunkArena()); + } +} + +bool ChunkAllocator::allocate(size_t size, Chunk* chunk) { + // fast path: allocate from current core arena + int core_id = CpuInfo::get_current_core(); + chunk->size = size; + chunk->core_id = core_id; + + if (_arenas[core_id]->pop_free_chunk(size, &chunk->data)) { + _reserved_bytes.fetch_sub(size); + local_core_alloc_count.increment(1); + return true; + } + if (_reserved_bytes > size) { + // try to allocate from other core's arena + for (int i = 1; i < _arenas.size(); ++i, ++core_id) { + if (_arenas[core_id % _arenas.size()]->pop_free_chunk(size, &chunk->data)) { Review comment: the arena picked in first loop is same as above ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
