imay commented on a change in pull request #1800: Fix bug that dead lock may
happen when drop table during alter table process
URL: https://github.com/apache/incubator-doris/pull/1800#discussion_r323807996
##########
File path: fe/src/main/java/org/apache/doris/alter/RollupJobV2.java
##########
@@ -165,8 +173,7 @@ protected void runPendingJob() {
try {
OlapTable tbl = (OlapTable) db.getTable(tableId);
if (tbl == null) {
- cancelImpl("Table " + tableId + " does not exist");
- return;
+ return new Status(TStatusCode.CANCELLED, "Table " + tableId +
" does not exist");
Review comment:
It likes C++, why not use Exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
