Re: 回复： Remove non-vectorization code

[Gabriel Lee]

+1. Make sense for both users and developers

Best,
Gabriel

On Tue, 6 Dec 2022 at 17:08, Mingyu Chen <morning...@163.com> wrote:

> Agreed.
> The non-vec code can be maintained on branch-1.1-lts, and branch-1.2-lts.
>
>
>
>
> --
>
> 此致！Best Regards
> 陈明雨 Mingyu Chen
>
> Email:
> morning...@apache.org
>
>
>
>
>
> 在 2022-12-06 16:24:00，"BiteTheDDDDt" <pxl...@qq.com.INVALID> 写道：
> >+1, it will be helpful
> >
> >
> >
> >
> >BiteTheDDDDt
> >pxl...@qq.com
> >
> >
> >
> >&nbsp;
> >
> >
> >
> >
> >------------------&nbsp;原始邮件&nbsp;------------------
> >发件人:
>                                                   "dev"
>                                                                 <
> ten...@outlook.com&gt;;
> >发送时间:&nbsp;2022年12月6日(星期二) 下午4:22
> >收件人:&nbsp;"dev@doris.apache.org"<dev@doris.apache.org&gt;;
> >
> >主题:&nbsp;Re: Remove non-vectorization code
> >
> >
> >
> >+1
> >
> >在 2022/12/6 13:38，“vin jake”<jakevin...@gmail.com&gt; 写入:
> >
> >&nbsp;&nbsp;&nbsp; +1
> >&nbsp;&nbsp;&nbsp; It's enough to keep non-vectorization code just in
> 1.1-lts
> >&nbsp;&nbsp;&nbsp; It's time to remove non-vectorization code now in
> master
> >
> >&nbsp;&nbsp;&nbsp; On Tue, Dec 6, 2022 at 12:23 PM GuoLei Yi <
> yiguo...@gmail.com&gt; wrote:
> >
> >&nbsp;&nbsp;&nbsp; &gt; Hi All Developers,
> >&nbsp;&nbsp;&nbsp; &gt;
> >&nbsp;&nbsp;&nbsp; &gt; Vectorization is introduced into Doris in 1.0
> which&nbsp; is released
> >&nbsp;&nbsp;&nbsp; &gt; earlier this year. Many companies is using 1.1.x
> and it is very very
> >&nbsp;&nbsp;&nbsp; &gt; Fast and Stable.&nbsp; I think it's time to
> remove non-vectorization code
> >&nbsp;&nbsp;&nbsp; &gt; now. Following is my considerations:
> >&nbsp;&nbsp;&nbsp; &gt;
> >&nbsp;&nbsp;&nbsp; &gt; - Lots of company is using doris 1.1.x and it is
> stable.
> >&nbsp;&nbsp;&nbsp; &gt; - 1.1-lts is a LTS branch, we will maintain it
> and fix bugs for it, If
> >&nbsp;&nbsp;&nbsp; &gt; you need non-vectorization code, I think 1.1 will
> solve your problem.
> >&nbsp;&nbsp;&nbsp; &gt; - 1.2 is now released, many features like array,
> JsonB, nest loop
> >&nbsp;&nbsp;&nbsp; &gt; join, decimalv3, datev2 and etc. are not
> implemented on
> >&nbsp;&nbsp;&nbsp; &gt; non-vectorization engine. So if a user is using
> 1.2 and using some new
> >&nbsp;&nbsp;&nbsp; &gt; features then it could not rollback to
> non-vectorization engine any
> >&nbsp;&nbsp;&nbsp; &gt; more.
> >&nbsp;&nbsp;&nbsp; &gt; - We need to refactor some code but we need to
> maintain these
> >&nbsp;&nbsp;&nbsp; &gt; non-vectorization code, it is very hard and it is
> very likely to
> >&nbsp;&nbsp;&nbsp; &gt; import BUGs and there are not many developers
> could add feature or fix
> >&nbsp;&nbsp;&nbsp; &gt; bugs for non-vectorization code.
> >&nbsp;&nbsp;&nbsp; &gt;
> >&nbsp;&nbsp;&nbsp; &gt; So that, I think it's time to remove
> non-vectorization code now to
> >&nbsp;&nbsp;&nbsp; &gt; move Fast and Stable!!!
> >&nbsp;&nbsp;&nbsp; &gt;
> >&nbsp;&nbsp;&nbsp; &gt; --
> >&nbsp;&nbsp;&nbsp; &gt; Best Regards,
> >&nbsp;&nbsp;&nbsp; &gt; Yi Guo Lei
> >&nbsp;&nbsp;&nbsp; &gt; SelectDB
> >&nbsp;&nbsp;&nbsp; &gt; The Best Cloud Native Platform for Apache Doris
> >&nbsp;&nbsp;&nbsp; &gt; Tel:134-3991-0228
> >&nbsp;&nbsp;&nbsp; &gt; Email:yiguo...@gmail.com
> >&nbsp;&nbsp;&nbsp; &gt;
> >&nbsp;&nbsp;&nbsp; &gt;
> ---------------------------------------------------------------------
> >&nbsp;&nbsp;&nbsp; &gt; To unsubscribe, e-mail:
> dev-unsubscr...@doris.apache.org
> >&nbsp;&nbsp;&nbsp; &gt; For additional commands, e-mail:
> dev-h...@doris.apache.org
> >&nbsp;&nbsp;&nbsp; &gt;
> >&nbsp;&nbsp;&nbsp; &gt;
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
> >For additional commands, e-mail: dev-h...@doris.apache.org
>