Here is my +1（binding）. I checked: [x] The download link is legal and the PGP signature are valid. [x] The source code matches the current release version. [x] The LICENSE and NOTICE files are correct.
Jiafeng.Zhang / 张家锋 Email: jiafengzh...@apache.org Mingyu Chen <morning...@163.com> 于2023年3月21日周二 20:47写道： > +1 (binding) > > > I would like to explain why we need this shade package for thrift. > Recently, the thrift version used by Doris has been upgraded from 0.13 to > 0.16. > And there are some new interface of thrift being introduced since thrift > 0.14, such as `TBinaryProtocol.checkStringReadLength`. > > > But when using HiveMetastore, it still use thrift 0.9 as its dependency, > so I met "java.lang.AbstractMethodError: null". > the thrift dependency of hive is "provided" so we can't change it. > > > So we decide to shade the thrift in Doris to solve this problem. After > this, the package name of thrift in Doris will be: > shade.doris.org.apache.thrift > > > > > -- > > Best Regards > Mingyu Chen > > Email: > morning...@apache.org > > > > > > At 2023-03-21 19:20:56, "wudi" <676366...@qq.com.INVALID> wrote: > >Hi all, > > > >This is a call for the vote to release Apache Doris-Shade 1.0.0 > > > >The git tag for the release: > >https://github.com/apache/doris-shade/releases/tag/doris-shade-1.0.0 < > https://github.com/apache/doris-shade/releases/tag/doris-shade-1.0.0> > > > >Release Notes are here: > > > https://github.com/apache/doris-shade/blob/doris-shade-1.0.0/CHANGE-LOG.txt > < > https://github.com/apache/doris-shade/blob/doris-shade-1.0.0/CHANGE-LOG.txt > > > > > >Thanks to everyone who has contributed to this release. > > > >The release candidates: > >https://dist.apache.org/repos/dist/dev/doris/doris-shade/ < > https://dist.apache.org/repos/dist/dev/doris/doris-shade/> > > > >This has been signed with PGP key > A692590313BF6657160079C0211FCDC7FC019983, corresponding to > >d...@apache.org. > > > >KEYS file is available here: > >https://downloads.apache.org/doris/KEYS < > https://downloads.apache.org/doris/KEYS> > > > >To verify and build, you can refer to following link: > >https://doris.apache.org/community/release-and-verify/release-verify < > https://doris.apache.org/community/release-and-verify/release-verify> > > > >The vote will be open for at least 72 hours. > > > >[ ] +1 Approve the release > >[ ] +0 No opinion > >[ ] -1 Do not release this package because … > > > > > >Brs, > >di.wu > > > > > > > > > > > -- 张家峰
