退订


---Original---
From: "ixtza (via GitHub)"<[email protected]&gt;
Date: Wed, Apr 15, 2026 14:15 PM
To: "dev"<[email protected]&gt;;
Subject: Re: [PR] [improve] Support schema table auto creation on struct record 
[doris-kafka-connector]



ixtza&nbsp;commented&nbsp;on&nbsp;code&nbsp;in&nbsp;PR&nbsp;#92:
URL:&nbsp;https://github.com/apache/doris-kafka-connector/pull/92#discussion_r3084363242


##########
src/test/java/org/apache/doris/kafka/connector/converter/schema/TestSchemaCreationManager.java:
##########
@@&nbsp;-0,0&nbsp;+1,264&nbsp;@@
+/*
+&nbsp;*&nbsp;Licensed&nbsp;to&nbsp;the&nbsp;Apache&nbsp;Software&nbsp;Foundation&nbsp;(ASF)&nbsp;under&nbsp;one
+&nbsp;*&nbsp;or&nbsp;more&nbsp;contributor&nbsp;license&nbsp;agreements.&nbsp;&nbsp;See&nbsp;the&nbsp;NOTICE&nbsp;file
+&nbsp;*&nbsp;distributed&nbsp;with&nbsp;this&nbsp;work&nbsp;for&nbsp;additional&nbsp;information
+&nbsp;*&nbsp;regarding&nbsp;copyright&nbsp;ownership.&nbsp;&nbsp;The&nbsp;ASF&nbsp;licenses&nbsp;this&nbsp;file
+&nbsp;*&nbsp;to&nbsp;you&nbsp;under&nbsp;the&nbsp;Apache&nbsp;License,&nbsp;Version&nbsp;2.0&nbsp;(the
+&nbsp;*&nbsp;"License");&nbsp;you&nbsp;may&nbsp;not&nbsp;use&nbsp;this&nbsp;file&nbsp;except&nbsp;in&nbsp;compliance
+&nbsp;*&nbsp;with&nbsp;the&nbsp;License.&nbsp;&nbsp;You&nbsp;may&nbsp;obtain&nbsp;a&nbsp;copy&nbsp;of&nbsp;the&nbsp;License&nbsp;at
+&nbsp;*
+&nbsp;*&nbsp;&nbsp;&nbsp;http://www.apache.org/licenses/LICENSE-2.0
+&nbsp;*
+&nbsp;*&nbsp;Unless&nbsp;required&nbsp;by&nbsp;applicable&nbsp;law&nbsp;or&nbsp;agreed&nbsp;to&nbsp;in&nbsp;writing,
+&nbsp;*&nbsp;software&nbsp;distributed&nbsp;under&nbsp;the&nbsp;License&nbsp;is&nbsp;distributed&nbsp;on&nbsp;an
+&nbsp;*&nbsp;"AS&nbsp;IS"&nbsp;BASIS,&nbsp;WITHOUT&nbsp;WARRANTIES&nbsp;OR&nbsp;CONDITIONS&nbsp;OF&nbsp;ANY
+&nbsp;*&nbsp;KIND,&nbsp;either&nbsp;express&nbsp;or&nbsp;implied.&nbsp;&nbsp;See&nbsp;the&nbsp;License&nbsp;for&nbsp;the
+&nbsp;*&nbsp;specific&nbsp;language&nbsp;governing&nbsp;permissions&nbsp;and&nbsp;limitations
+&nbsp;*&nbsp;under&nbsp;the&nbsp;License.
+&nbsp;*/
+
+package&nbsp;org.apache.doris.kafka.connector.converter.schema;
+
+import&nbsp;static&nbsp;org.mockito.Mockito.mockStatic;
+
+import&nbsp;java.io.IOException;
+import&nbsp;java.io.InputStream;
+import&nbsp;java.nio.charset.StandardCharsets;
+import&nbsp;java.util.HashMap;
+import&nbsp;java.util.Map;
+import&nbsp;java.util.Properties;
+import&nbsp;org.apache.doris.kafka.connector.cfg.DorisOptions;
+import&nbsp;org.apache.doris.kafka.connector.cfg.DorisSinkConnectorConfig;
+import&nbsp;org.apache.doris.kafka.connector.converter.RecordDescriptor;
+import&nbsp;org.apache.doris.kafka.connector.converter.RecordTypeRegister;
+import&nbsp;org.apache.doris.kafka.connector.service.RestService;
+import&nbsp;org.apache.doris.kafka.connector.writer.TestRecordBuffer;
+import&nbsp;org.apache.kafka.connect.data.SchemaAndValue;
+import&nbsp;org.apache.kafka.connect.json.JsonConverter;
+import&nbsp;org.apache.kafka.connect.sink.SinkRecord;
+import&nbsp;org.junit.After;
+import&nbsp;org.junit.Assert;
+import&nbsp;org.junit.Before;
+import&nbsp;org.junit.Test;
+import&nbsp;org.mockito.MockedStatic;
+
+public&nbsp;class&nbsp;TestSchemaCreationManager&nbsp;{
+
+&nbsp;&nbsp;&nbsp;&nbsp;private&nbsp;JsonConverter&nbsp;jsonConverter&nbsp;=&nbsp;new&nbsp;JsonConverter();
+&nbsp;&nbsp;&nbsp;&nbsp;private&nbsp;SchemaCreationManager&nbsp;schemaCreationManager;
+&nbsp;&nbsp;&nbsp;&nbsp;private&nbsp;RecordTypeRegister&nbsp;recordTypeRegister;
+&nbsp;&nbsp;&nbsp;&nbsp;private&nbsp;Properties&nbsp;props&nbsp;=&nbsp;new&nbsp;Properties();
+&nbsp;&nbsp;&nbsp;&nbsp;private&nbsp;MockedStatic<RestService&gt;&nbsp;mockRestService;
+
+&nbsp;&nbsp;&nbsp;&nbsp;@Before
+&nbsp;&nbsp;&nbsp;&nbsp;public&nbsp;void&nbsp;init()&nbsp;throws&nbsp;IOException&nbsp;{
+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;InputStream&nbsp;stream&nbsp;=
+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;this.getClass()
+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;.getClassLoader()
+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;.getResourceAsStream("doris-connector-sink.properties");
+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;props.load(stream);

Review&nbsp;Comment:
&nbsp;&nbsp;&nbsp;Accepted.



--&nbsp;
This&nbsp;is&nbsp;an&nbsp;automated&nbsp;message&nbsp;from&nbsp;the&nbsp;Apache&nbsp;Git&nbsp;Service.
To&nbsp;respond&nbsp;to&nbsp;the&nbsp;message,&nbsp;please&nbsp;log&nbsp;on&nbsp;to&nbsp;GitHub&nbsp;and&nbsp;use&nbsp;the
URL&nbsp;above&nbsp;to&nbsp;go&nbsp;to&nbsp;the&nbsp;specific&nbsp;comment.

To&nbsp;unsubscribe,&nbsp;e-mail:&nbsp;[email protected]

For&nbsp;queries&nbsp;about&nbsp;this&nbsp;service,&nbsp;please&nbsp;contact&nbsp;Infrastructure&nbsp;at:
[email protected]


---------------------------------------------------------------------
To&nbsp;unsubscribe,&nbsp;e-mail:&nbsp;[email protected]
For&nbsp;additional&nbsp;commands,&nbsp;e-mail:&nbsp;[email protected]

Reply via email to