diggle1 commented on PR #99: URL: https://github.com/apache/doris-kafka-connector/pull/99#issuecomment-4437205724
> @diggle1 Thanks for your contribution～ The code implementation is somewhat complex, and the two configurations of `connector` you added pose a high learning curve for users. I think it would be better to use internal constants for the cache expiration time of `be` without adding additional configurations. @rnb-tron Thanks for the review! Makes sense — I'll simplify the change by: Removing the two new configs (backend.cache.ttl.ms and backend.probe.timeout.ms) and using internal constants in BackendUtils instead (planned defaults: cache TTL = 60s, probe connect timeout = 5s, down from the previous hard-coded 60s). Inlining the cache logic so BackendUtils stays small — keep getAvailableBackend() / invalidateCache() as the only public surface change, and revert DorisOptions / DorisSinkConnectorConfig to their original state. Keeping the invalidateCache() calls on stream-load / commit failure so a bad BE is dropped from the cache immediately. Please let me know if the default TTL / probe timeout values look reasonable to you, or if you'd prefer different numbers. I'll push an updated commit shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
